Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 9, 2024

This is a follow-up pull request for #19164, which removes the further handling of older Qt versions.

Ping @ravinikam @stkrwork @etherealjoy @muttleyxd

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

This is a follow-up pull request for [#19164] (#19164), which removes the further handling of older Qt versions.
@wing328
Copy link
Member

wing328 commented Oct 10, 2024

Copy link
Contributor

@muttleyxd muttleyxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but as wing328 mentioned - please update samples

@ghost
Copy link
Author

ghost commented Oct 11, 2024

Thx for the review. I will update the samples the next days.

@wing328 wing328 added this to the 7.10.0 milestone Oct 14, 2024
@wing328 wing328 merged commit 8849156 into OpenAPITools:master Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants