Skip to content

Conversation

@a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Oct 1, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@a-wallen a-wallen force-pushed the zapier_response_middleware branch from 7dafbc8 to 855e109 Compare October 1, 2024 00:18
@a-wallen a-wallen changed the title Zapier response middleware [feat] add zapier response middleware Oct 1, 2024
@a-wallen
Copy link
Contributor Author

a-wallen commented Oct 1, 2024

closes #19300

@a-wallen
Copy link
Contributor Author

a-wallen commented Oct 1, 2024

cc @valmoz, @emajo

@a-wallen a-wallen force-pushed the zapier_response_middleware branch from 5fad71d to a6ef400 Compare October 1, 2024 00:46
@a-wallen a-wallen force-pushed the zapier_response_middleware branch from a6ef400 to bd8e9ef Compare October 1, 2024 00:52
@a-wallen
Copy link
Contributor Author

a-wallen commented Oct 1, 2024

any idea why 0ce2ef7 is in this? (even after this PR landed: #19670)

@wing328
Copy link
Member

wing328 commented Oct 1, 2024

any idea why 0ce2ef7 is in this? (even after this PR landed: #19670)

my guess is that you created a new branch based on the branch containing 0ce2ef7

@wing328
Copy link
Member

wing328 commented Oct 1, 2024

you may want to create a new PR by cherry-picking commits

@a-wallen
Copy link
Contributor Author

a-wallen commented Oct 2, 2024

I'm closing this since #19760 contains a clean branch with the changes + regenerated samples.

@wing328 I saw that you opened #19746 which does the same thing. You got my LGTM if you want to reopen that and land it instead,

@a-wallen a-wallen closed this Oct 2, 2024
@a-wallen a-wallen mentioned this pull request Oct 2, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants