Skip to content

Conversation

@NelsonVides
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    Not sure if mentioning, as they unfortunately haven't been fully active 🥲 However, tagging @wing328, as you helped me out with Erlang server overhaul #19465 🙂

I've been using this generator further in more complex code, submitting some fixes I've been discovering over my previous overhaul.

@NelsonVides
Copy link
Contributor Author

@wing328, if the previous tech committee would agree, maybe I could candidate myself to be a part of it? I don't know how it works and what I'd need to do, but I've essentially become the maintainer of the full rewrite 😄

@wing328
Copy link
Member

wing328 commented Sep 11, 2024

yes please add yourself to the Erlang technical committee in the project's readme

@NelsonVides
Copy link
Contributor Author

Added, thank you :)

@wing328 wing328 merged commit d02aae7 into OpenAPITools:master Sep 12, 2024
@NelsonVides NelsonVides deleted the erlang-server branch September 12, 2024 09:00
@wing328
Copy link
Member

wing328 commented Sep 16, 2024

when you've time this week or next, can you please PM me via Slack?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants