Skip to content

[csharp] Mustache fully qualify namespace for Path #19349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 3 commits into from
Oct 30, 2024
Merged

[csharp] Mustache fully qualify namespace for Path #19349

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fd1374
fix: csharp mustash fully qualify namespace Path
alfredo-accuris Aug 13, 2024
6d7ed68
mend
alfredo-accuris Aug 13, 2024
cf70b7a
Remove alias for fully qualify Path class
alfredo-accuris Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/openapi-generator/src/main/resources/csharp/ApiClient.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ using RestSharp;
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;

@devhl-labs devhl-labs Aug 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an alias might lead to more conflicts with other apis that have objects called Path. Please just fully qualify the Path method without using an alias.

@alfredo-accuris alfredo-accuris Aug 14, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the PR. Fully qualify Path class

@wing328 wing328 Aug 21, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;

given that we're already using aliases above, shall we follow the same pattern for Path to make it consistent? e.g.

using PathIO = System.IO.Path;

@devhl-labs devhl-labs Aug 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we should be using aliases. That will make it easier for unexpected conflicts to occur. Using the fully qualified name is more verbose, but also more concise. We don't care about verbosity here because it is generated code anyway.

@wing328 wing328 Oct 30, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't care about verbosity here because it is generated code anyway.

some users do care about it based on feedback we'd previously when using fully qualified namespace

i don't think giving this one a try

{{#supportsRetry}}
using Polly;
{{/supportsRetry}}
Expand Down
1 change: 1 addition & 0 deletions samples/client/echo_api/csharp-restsharp/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Model;

Expand Down
1 change: 1 addition & 0 deletions samples/client/others/csharp-complex-files/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Model;

Expand Down
1 change: 1 addition & 0 deletions ...store/csharp/restsharp/net4.7/MultipleFrameworks/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Client.Auth;
using Org.OpenAPITools.Model;
Expand Down
1 change: 1 addition & 0 deletions ...client/petstore/csharp/restsharp/net4.7/Petstore/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Client.Auth;
using Org.OpenAPITools.Model;
Expand Down
1 change: 1 addition & 0 deletions ...client/petstore/csharp/restsharp/net4.8/Petstore/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Client.Auth;
using Org.OpenAPITools.Model;
Expand Down
1 change: 1 addition & 0 deletions ...petstore/csharp/restsharp/net6/ParameterMappings/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Model;

Expand Down
1 change: 1 addition & 0 deletions ...ient/petstore/csharp/restsharp/net7/EnumMappings/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Client.Auth;
using Org.OpenAPITools.Model;
Expand Down
1 change: 1 addition & 0 deletions ...s/client/petstore/csharp/restsharp/net7/Petstore/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Client.Auth;
using Org.OpenAPITools.Model;
Expand Down
1 change: 1 addition & 0 deletions ...etstore/csharp/restsharp/net7/UseDateTimeForDate/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Model;

Expand Down
1 change: 1 addition & 0 deletions ...p/restsharp/standard2.0/ConditionalSerialization/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Client.Auth;
using Org.OpenAPITools.Model;
Expand Down
1 change: 1 addition & 0 deletions ...t/petstore/csharp/restsharp/standard2.0/Petstore/src/Org.OpenAPITools/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
using RestSharp.Serializers;
using RestSharpMethod = RestSharp.Method;
using FileIO = System.IO.File;
using Path = global::System.IO.Path;
using Polly;
using Org.OpenAPITools.Client.Auth;
using Org.OpenAPITools.Model;
Expand Down