Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] Convert numbers to long when min/max is too big #19290

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Aug 3, 2024

Fixing number types to be longs if appropriate. The format is supposed to tell us the specific type, but the format is not required, so we can infer from the mim/max. This logic should be moved to the default codegen, just not sure where.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@devhl-labs devhl-labs marked this pull request as draft August 3, 2024 19:40
@devhl-labs devhl-labs marked this pull request as ready for review August 3, 2024 19:41
@devhl-labs devhl-labs marked this pull request as draft August 3, 2024 20:32
@devhl-labs devhl-labs marked this pull request as ready for review August 3, 2024 22:58
@wing328 wing328 merged commit 2bc4a16 into OpenAPITools:master Aug 4, 2024
44 checks passed
@devhl-labs devhl-labs deleted the convert-to-long branch August 4, 2024 12:17
@wing328 wing328 added this to the 7.8.0 milestone Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants