Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bytestring package to dependencies of generated haskell code #19088

Conversation

bholst
Copy link
Contributor

@bholst bholst commented Jul 5, 2024

This broke in #18047 where tvh introduced an import of Data.ByteString.Lazy. The added bytestring package was available in some but not all cases.

I tested the generation of our own openapi package and compiled it successfully.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

This broke in OpenAPITools#18047
where tvh introduced an import of Data.ByteString.Lazy. The added
bytestring package was available in some but not all cases.
@wing328
Copy link
Member

wing328 commented Jul 6, 2024

thanks for the PR

cc @tvh (author of #18047)

@wing328
Copy link
Member

wing328 commented Jul 6, 2024

I tested the generation of our own openapi package and compiled it successfully.

can you please share a minimal test spec to reproduce the issue?

@wing328
Copy link
Member

wing328 commented Jul 7, 2024

I've filed #19101 and added a test with ping.yaml (which doesn't have any security settings/schemes)

@wing328
Copy link
Member

wing328 commented Jul 7, 2024

closing this one as we've merged #19101 in which you and I are listed as co-authors

@wing328 wing328 closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants