Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin] Fix a leak in the ApiClient #18997

Merged

Conversation

gosusnp
Copy link
Contributor

@gosusnp gosusnp commented Jun 21, 2024

This should address #18996.

We tracked down a memory leak from the generated api client in kotlin.
The okhttp3.Response is closeable and isn't closed. This commit shows the fix we did on in Airbyte that addressed the leak.

The fix I am proposing here is to wrap the usage of the okhttp3.Response in a .use {} block.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@gosusnp
Copy link
Contributor Author

gosusnp commented Jun 21, 2024

Dear TC members @jimschubert (2017/09), @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06), please take a look when you get a chance.

@wing328
Copy link
Member

wing328 commented Jun 23, 2024

thanks for the fix.

let's give it a try

@wing328 wing328 merged commit 4e89436 into OpenAPITools:master Jun 23, 2024
58 checks passed
@wing328 wing328 added this to the 7.7.0 milestone Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants