Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Add Flag to Allow Ignoring Operation Servers #18981

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

ckoegel
Copy link
Contributor

@ckoegel ckoegel commented Jun 19, 2024

Similar to #18934.

This change adds a flag to the configuration object to allow for ignoring operation servers. Currently, if operation level server objects are defined, there is no way to ignore these or use a different base path at the SDK level, which many other languages support. The new ignore_operation_servers flag allows the user to ignore any operation servers defined and instead use the currently defined host. This will default to the top level base path defined in the OpenAPI file, but can be configured to be any url by setting the host for the configuration object.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

@ckoegel ckoegel marked this pull request as ready for review June 20, 2024 18:29
@wing328 wing328 added this to the 7.7.0 milestone Jun 24, 2024
@wing328
Copy link
Member

wing328 commented Jun 25, 2024

thanks for the PR, which looks good.

if no further feedback, I'll merge it tomorrow

@wing328 wing328 merged commit 0d05ee3 into OpenAPITools:master Jun 26, 2024
35 checks passed
@ckoegel ckoegel deleted the python-ignore-os branch June 26, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants