Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift] Rename url & path variables to avoid collision #18969

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

andyland
Copy link
Contributor

Fixes Issue 18940

This renames the url & path variables to localVarURL and localVarPath to reduce the likelihood of collisions with parameters in the API request

@dydus0x14

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.7.0 milestone Jun 19, 2024
@wing328 wing328 changed the title [swift] Issue 18940: Rename url & path variables to avoid collision [swift] Rename url & path variables to avoid collision Jun 19, 2024
@wing328
Copy link
Member

wing328 commented Jun 19, 2024

lgtm

cc
@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)

@wing328 wing328 merged commit a4b577d into OpenAPITools:master Jun 19, 2024
15 checks passed
@wing328
Copy link
Member

wing328 commented Jun 19, 2024

@andyland thanks for the fix, which has been merged.

please give it a try with the latest master or the snapshot version (published later via Travis CI workflow) to confirm the fix works as expected.

thanks again for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compilation error in swift-combine generation with query param named url or path
2 participants