Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load vendorExtensions in the operation parameter #18962

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

rodrigoma3
Copy link
Contributor

@rodrigoma3 rodrigoma3 commented Jun 18, 2024

Load vendorExtensions in the operation parameter when openapi 3
Unit test to verify that the API changed the annotation
fix #18959

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @wing328

@rodrigoma3
Copy link
Contributor Author

@wing328 @welshm @borsch

@rodrigoma3 rodrigoma3 requested a review from welshm June 20, 2024 21:21
@rodrigoma3
Copy link
Contributor Author

@wing328 @borsch Could you evaluate the PR please?

@@ -5121,6 +5121,9 @@ public CodegenParameter fromParameter(Parameter parameter, Set<String> imports)
if (parameter.getExtensions() != null && !parameter.getExtensions().isEmpty()) {
codegenParameter.vendorExtensions.putAll(parameter.getExtensions());
}
if (parameter.getSchema() != null && parameter.getSchema().getExtensions() != null && !parameter.getSchema().getExtensions().isEmpty()) {
codegenParameter.vendorExtensions.putAll(parameter.getSchema().getExtensions());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Jun 24, 2024

tested locally and the result is good

thanks for the PR

@wing328 wing328 merged commit 5532203 into OpenAPITools:master Jun 24, 2024
15 checks passed
@wing328 wing328 changed the title Fix Issue 18959 - Load vendorExtensions in the operation parameter when openapi 3 Load vendorExtensions in the operation parameter when openapi 3 Jun 24, 2024
@wing328 wing328 changed the title Load vendorExtensions in the operation parameter when openapi 3 Load vendorExtensions in the operation parameter Jun 24, 2024
@wing328 wing328 added this to the 7.7.0 milestone Jun 24, 2024
@rodrigoma3
Copy link
Contributor Author

tested locally and the result is good

thanks for the PR

I appreciate your attention. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA][Spring] Pattern message not working in path param, query param and header param
3 participants