Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] OneOf should handle Inheritance based type #18892

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

Ghufz
Copy link
Contributor

@Ghufz Ghufz commented Jun 10, 2024

In the current C# generator, properties that have a oneOf relationship only handle the relationship for concrete types. However, if a schema in the oneOf clause is an abstract type, it should accept types derived from the abstract class. Unfortunately, this behavior is not possible in the current C# generator. I’ve implemented a fix to handle inheritance-based type checks using the is operator.

The current generator generate a code as below for oneOf schema

public override Object ActualInstance
        {
            get
            {
                return _actualInstance;
            }
            set
            {
                if (value.GetType() == typeof(FabricAbstractInterfaceRole))
                {
                    this._actualInstance = value;
                }
                else if (value.GetType() == typeof(MoMoRef) )
                {
                    this._actualInstance = value;
                }
                else
                {
                    throw new ArgumentException("Invalid instance found. Must be the following types: FabricAbstractInterfaceRole, MoMoRef");
                }
            }
        }


Expected behaviour to accepts any type which are derived from abstract class

public override Object ActualInstance
        {
            get
            {
                return _actualInstance;
            }
            set
            {
                if (value.GetType() == typeof(FabricAbstractInterfaceRole) || value is FabricAbstractInterfaceRole)
                {
                    this._actualInstance = value;
                }
                else if (value.GetType() == typeof(MoMoRef) || value is MoMoRef )
                {
                    this._actualInstance = value;
                }
                else
                {
                    throw new ArgumentException("Invalid instance found. Must be the following types: FabricAbstractInterfaceRole, MoMoRef");
                }
            }
        }


PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @wing328

@wing328
Copy link
Member

wing328 commented Jun 11, 2024

thanks for the PR

cc
@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

@wing328
Copy link
Member

wing328 commented Jun 15, 2024

@wing328 wing328 merged commit 3d93862 into OpenAPITools:master Jun 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants