[typescript-fetch] - Fix Nullable Types #18887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17798 introduced a breaking change where the distinction between
undefined
andnullable
was lost.The original contributor of this PR explained his rationale here for doing this, which is wrong:
#17798 (comment)
Take the instance where we do a
PATCH
request and I want to partially update an entity. That means I would be able to pass in a partial object with subset of the fields.Here's a definition of what a patch could look like, you can optionally pass any of the parameters. In this case, the
subTitle
field is alsonullable
, which would make itnull
in the database if I wanted to erase it:Scenario 1: Patching
title
only, I don't pass insubTitle
Scenario 2: Patching
subTitle
only, making itnull
. Now I can't do this, because the types are broken:subTitle
isnullable: true
inswagger.json
:In previous versions
7.3.0
and down the output was this:Since this PR has been merged:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)