Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc in clioption #188

Merged
merged 3 commits into from
Jun 3, 2018

Conversation

jmini
Copy link
Member

@jmini jmini commented May 30, 2018

See issue #63.

A new warning was introduced with #160:

/**
* Create new boolean command line option with the provided value as default
*
* @param opt Option name
* @param description Option description
* @param defaultValue the default value to use if option not specified
* @return
*/
public static CliOption newBoolean(String opt, String description, boolean defaultValue) {
return new CliOption(opt, description, SchemaTypeUtil.BOOLEAN_TYPE).defaultValue(String.valueOf(defaultValue));
}

I have fixed it and I have now configured the build to fail when new warnings are created.

@wing328 wing328 added this to the 3.0.1 milestone Jun 3, 2018
@wing328 wing328 merged commit 501245d into OpenAPITools:master Jun 3, 2018
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 4, 2018
* master:
  Fix javadoc in clioption (OpenAPITools#188)
  Build improvements (OpenAPITools#202)
  Prepare 3.0.1-SNAPSHOT (OpenAPITools#195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants