[GO] Add assert constraints checks for complex types in the model template #18654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivlevitski-vlz
force-pushed
the
go-add-assert-constraints-checks-for-complex-types
branch
from
c70a002
to
d2c6f41
Compare
avivlevitski-vlz
changed the title
avivlevitski-vlz
force-pushed
the
go-add-assert-constraints-checks-for-complex-types
branch
from
d2c6f41
to
0efed8b
Compare
|
can you please review the test failure when you've time? |
wing328
reviewed
May 14, 2024
| // This method traverse nested slices in a preorder fashion. | ||
| func AssertRecurseInterfaceRequired[T any](obj interface{}, callback func(T) error) error { | ||
| return AssertRecurseValueRequired(reflect.ValueOf(obj), callback) | ||
| func AssertRecurseInterface[T any](obj interface{}, callback func(T) error) error { |
There was a problem hiding this comment.
is it a must to rename this function? i'm afraid this may break the usage of our existing users
same for line 49
There was a problem hiding this comment.
Not must, it's a more generic name due to the usage of both the required and constraints
There was a problem hiding this comment.
I suggest we keep the original/old name for the time being and rename it in the upcoming 8.0.x as some users do not like these kinda breaking changes in a minor release.
There was a problem hiding this comment.
another way is to keep the old function name (underlying it's calling the new function) and mark it as deprecated
wing328
changed the title
|
thanks for the PR. let's give it a try |
renatomameli
pushed a commit
to renatomameli/openapi-generator
that referenced
this pull request
May 17, 2024
…plate (OpenAPITools#18654) * [GO] Add assert constraints checks for complex types in the model template * [GO] Update samples * [GO] revert AssertRecurseInterface naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to close #18651
Add assert constraints checks for complex types in the model template.
Every nested model will be validated (if necessary according to the component schema format).
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5