[BUG][JAVA] oneOf/anyOf multiple constructors with same erasure #18548 #18645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
May 13, 2024
| @@ -210,13 +210,11 @@ public class {{classname}} extends AbstractOpenApiSchema{{#vendorExtensions.x-im | |||
| super("anyOf", {{#isNullable}}Boolean.TRUE{{/isNullable}}{{^isNullable}}Boolean.FALSE{{/isNullable}}); | |||
| } | |||
|
|
|||
| {{#anyOf}} | |||
| public {{classname}}({{{.}}} o) { | |||
| public {{classname}}(Object o) { | |||
There was a problem hiding this comment.
fyi. this is consistent with the constructor implementation in oneOf
wing328
added
Breaking change (without fallback)
Client: Java
Issue: Bug
and removed
Breaking change (without fallback)
labels
renatomameli
pushed a commit
to renatomameli/openapi-generator
that referenced
this pull request
May 17, 2024
…PITools#18548 (OpenAPITools#18645) * [BUG][JAVA] oneOf/anyOf multiple constructors with same erasure OpenAPITools#18548 * [BUG][JAVA] oneOf/anyOf multiple constructors with same erasure OpenAPITools#18548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compilation error that appears in generated oneOf and anyOf classes using the okhttp-gson library.
A more detailed explanation can be found in the issue description: #18548
Additionally, two new URLs have been added in
modules/openapi-generator/src/test/resources/3_0/java/petstore-with-fake-endpoints-models-for-testing-okhttp-gson.yaml, these requests can be used to test this change.I also ended up fixing another bug with incorrect variable names when using array types that caused my tests to fail (see adfc6ef, there don't appear to be any issues regarding this error, so I pushed the fix here in order for the tests to pass).
I also didn't add any new tests since the validation and serialization logic weren't modified, the new sample requests will fail the CI tests if the bug occurs.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg