rust server: Silence clippy lints by refactoring #18575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A clippy lint recommends not using a closure inside of a statement. The code generation used to produce code that triggered this warning, which caused the rust-server integration test to fail because clippy is configured to return lint violations as errors. For details for the lint see: https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions
A GitHub action test used to fail because of a clippy warning that was emitted due to not using an imported symbol but qualifying its use. A failed test can be seen here: https://github.com/OpenAPITools/openapi-generator/actions/runs/8958257509/job/24603984954?pr=18563 With the relevant error being: error: unnecessary qualification --> output/openapi-v3/src/client/callbacks.rs:88:9 | 88 | futures::future::ok(Service::new( This commit simply removes the qualification.
Updated examples by running `./bin/generate-samples.sh ./bin/configs/rust-server-*` The integration test with the following command passes: `mvn integration-test -f samples/server/petstore/rust-server/pom.xml`
5 tasks
|
lgtm. thanks for the quick fix |
wing328
added
Server: Rust
Enhancement: Code Cleanup
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18572.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10)