-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp] make the method GetHttpSignedHeader of HttpSigningConfiguration public to get signed header. #18481
Conversation
Merge upstream fixes
update with upstream master
…tor into feature/refresh_master
regular merge code from upstream
…tor into refresh/master
Merge upstream code to master
…tor into refresh/master
pulling in the python set-item fix from master
…tor into refresh/master
pull in golang restrict read-only props changes from upstream
…tor into refresh/upstream
Pull in latest upstream code
…ul_2022 Pull latest upstream code
update using cisco m31
modules/openapi-generator/src/main/resources/python-pydantic-v1/signing.mustache
Outdated
Show resolved
Hide resolved
appveyor (windows) tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/49687286 |
closed via #18496 (cherry-picking a commit in this PR) instead. next time, please try to do a fresh fork of https://github.com/openAPITools/openapi-generator before making the change and filing the PR as that would help avoid 20+ unnecessary commits as illustrated in this PR. |
HttpSigningConfiguration class provides the HttpSigned header which is used for httpSIgning Authentication. the function GetHttpSignedHeader of the class HttpSigningConfiguration was declared with access specifier internal which restrict user to get the signed header outside the assembly. to make the developer life easy and use the HttpSigningConfiguration class as utlity for httpSigning I have made the function to public so that it can be accessed outside assembly.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@wing328