Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @Valid even for enum types defined in components #18451

Merged
merged 11 commits into from
May 14, 2024

Conversation

CREKD127
Copy link
Contributor

@CREKD127 CREKD127 commented Apr 22, 2024

fixes #18430

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Apr 22, 2024

thanks for the PR. please follow step 3 to update the samples so that CI can verify the change

@CREKD127
Copy link
Contributor Author

@wing328
Is this correctly following step3?

@wing328
Copy link
Member

wing328 commented Apr 22, 2024

don't think so. let me try to fix it for you later

@wing328
Copy link
Member

wing328 commented Apr 22, 2024

update: i've filed #18453 instead

@wing328
Copy link
Member

wing328 commented May 8, 2024

cc
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@CREKD127
Copy link
Contributor Author

CREKD127 commented May 8, 2024

@wing328
Copy link
Member

wing328 commented May 8, 2024

i've just merged #18606 to improve the tests in the jaxrs-spec generator.

can you please merge the latest master into your branch and add a test or 2 in modules/openapi-generator/src/test/resources/3_0/jaxrs-spec/petstore-with-fake-endpoints-models-for-testing.yaml ?

@wing328 wing328 merged commit d5559d5 into OpenAPITools:master May 14, 2024
36 checks passed
@wing328 wing328 added this to the 7.6.0 milestone May 14, 2024
@wing328 wing328 mentioned this pull request May 14, 2024
5 tasks
@wing328
Copy link
Member

wing328 commented May 14, 2024

update: added a test via #18664. please have a look to sese if the result looks good to you.

renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
…#18451)

* Update beanValidation.mustache

* step 3

* Revert "step 3"

This reverts commit 73ba918.

* update mustache

* #

* isContainer

* step3

* ^

* fix
@wing328
Copy link
Member

wing328 commented May 17, 2024

filed and merged #18697 as a follow-up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JAVA] [JAXRS] [BUG] Enums Decorated with @Valid in Componentized Classes
2 participants