-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @Valid even for enum types defined in components #18451
Conversation
thanks for the PR. please follow step 3 to update the samples so that CI can verify the change |
@wing328 |
don't think so. let me try to fix it for you later |
update: i've filed #18453 instead |
cc |
i've just merged #18606 to improve the tests in the jaxrs-spec generator. can you please merge the latest master into your branch and add a test or 2 in |
update: added a test via #18664. please have a look to sese if the result looks good to you. |
filed and merged #18697 as a follow-up PR |
fixes #18430
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)