Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mutiny support to JaxRS #18389

Merged

Conversation

lizzyTheLizard
Copy link
Contributor

As described in #18388 I ported the useMutiny-Feature from kotlin-server to the Jax-RS generator. Mutiny is especially useful for Quarkus as it is the default async framework. This change will not have any effect on other libraries than Quarkus and by default will be switched off.

I adapted the tests, documentation and samples as good as I could. However, the sample does not work due to #7994. I might work on that bug in the foreseeable future, but I did not want to include it into this PR.

I would be glad if @bbdouglas, @sreeshas, @jfiala, @lukoyanov, @cbornet, @jeff9finger, @karismann, @Zomzog, @lwlee2608 or @martin-mfg could have a look

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Apr 17, 2024

lgtm. thanks for the PR

@wing328 wing328 merged commit 213564a into OpenAPITools:master Apr 17, 2024
35 checks passed
@wing328
Copy link
Member

wing328 commented Apr 17, 2024

can you please PM me via Slack when you've time?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328 wing328 changed the title #18388: Add Mutiny support to JaxRS Add Mutiny support to JaxRS Apr 17, 2024
@lizzyTheLizard lizzyTheLizard deleted the issue-18388-port-mutiny-to-jaxrs branch April 17, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants