Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin] better oneOf, anyOf support #18382

Merged
merged 17 commits into from
May 31, 2024
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Apr 14, 2024

better oneOf, anyOf support via the option generateOneOfAnyOfWrappers

with this option enabled, oneOf, anyOf schemas will be generated as wrapper/container similar to the Java client implementation of oneOf, anyOf.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 removed this from the 7.6.0 milestone Apr 22, 2024
@wing328 wing328 changed the title [kotlin] better oneOf support [kotlin] better oneOf, anyOf support May 27, 2024
@wing328 wing328 marked this pull request as ready for review May 27, 2024 13:53
@wing328
Copy link
Member Author

wing328 commented May 27, 2024

cc
@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@wing328 wing328 merged commit 353320c into master May 31, 2024
64 checks passed
@wing328 wing328 deleted the java-okhttp-gson-to-kotlin branch May 31, 2024 04:22
welshm pushed a commit to welshm/openapi-generator that referenced this pull request Jun 5, 2024
* add validteJsonElement

* add oneOf support

* various fixes, add tests

* minor fixes

* minor fixes

* update data class

* remove comments

* array support, add test

* update api client constructor

* add anyOf support

* add new files

* fix merge

* update

* update

* update

* update
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants