Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-symfony] Allow Symfony 7 / Remove EOL PHP / Bearer Fix #18357

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

dmetzner
Copy link
Contributor

@dmetzner dmetzner commented Apr 11, 2024

  • add Symfony 7 support
  • remove support php < 8.2 (EOL)
  • remove symfony < 6.4 support

Bug Fix

Misc

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@dmetzner dmetzner changed the base branch from master to 8.0.x April 11, 2024 14:00
@dmetzner dmetzner changed the title [php-symfony] Allow Symfony 7 & more [php-symfony] Allow Symfony 7 / Remove EOL / Bearer Fix Apr 11, 2024
@dmetzner
Copy link
Contributor Author

@ksm2 @BenjaminHae

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@dmetzner dmetzner marked this pull request as ready for review April 11, 2024 14:35
@wing328
Copy link
Member

wing328 commented Apr 11, 2024

thanks for the PR

i notice that this PR targets 8.0.x (upcoming major release)

is it correct to say that this PR contains breaking changes (without fallbacks)?

@dmetzner
Copy link
Contributor Author

dmetzner commented Apr 11, 2024

@wing328

While this PR allows Symfony 7.0, it fully removes support for PHP versions 7.4/8.0 and Symfony versions 5.0-6.3. Hence, I'd say it is a breaking change, similar to this PR "drop support for EOLed PHP versions and unify min required version"

Nevertheless, adding the non-breaking parts of the PR to version 7 is possible. (Non-breaking PR)

@dmetzner dmetzner changed the title [php-symfony] Allow Symfony 7 / Remove EOL / Bearer Fix [php-symfony] Allow Symfony 7 / Remove EOL PHP / Bearer Fix Apr 11, 2024
@dkarlovi
Copy link
Contributor

Removing support for deps is not a breaking change. The user will just not get the update.

@dmetzner dmetzner changed the base branch from 8.0.x to master April 12, 2024 07:13
@dmetzner
Copy link
Contributor Author

@dkarlovi Thanks for the information. Changed the target branch back to master

@dmetzner dmetzner force-pushed the php-symfony/eol-with-fixes branch 2 times, most recently from 9b09695 to 2978098 Compare April 12, 2024 07:17
Bump requirements
  - add Symfony 7 support
  - remove support php < 8.2 (EOL)
  - remove symfony < 6.4 support

Bug Fix
  - add missing $security{{name}} variable when using Bearer Auth

Misc
 - getContentType method is deprecated; use getContentTypeFormat
 - use match instead of switch for simple assignments
 - remove default depth param from json_encode call
 - make data provider static (phpunit)
@wing328 wing328 added Enhancement: General Issue: Bug Server: PHP Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Apr 13, 2024
@wing328 wing328 added this to the 7.5.0 milestone Apr 13, 2024
@wing328
Copy link
Member

wing328 commented Apr 13, 2024

also tested locally and the result seems good:

Tests: 63, Assertions: 22, Deprecations: 116, Skipped: 47, Risky: 20.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:30 min
[INFO] Finished at: 2024-04-13T10:43:13+08:00
[INFO] ------------------------------------------------------------------------
[INFO] 3 goals, 3 executed
[INFO] Cleaning up the local build cache...
[INFO] Deleted 0 unused files from the local build cache in 0.004s
[INFO] ------------------------------------------------------------------------

@wing328 wing328 merged commit 8155d03 into OpenAPITools:master Apr 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Enhancement: General Issue: Bug Server: PHP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants