Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove param tag for non-existent parameter in ObjectSerializer #18347

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

szepeviktor
Copy link
Contributor

@phpstan discovered this param tag.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Apr 10, 2024

please follow step 3 to update the samples so that the CI can verify the change.

@szepeviktor
Copy link
Contributor Author

Thank you.

I do not have Java environment on my linux instance.
But I have a text editor! ✈️

@szepeviktor
Copy link
Contributor Author

update the samples

@wing328 Done 🍏

@wing328
Copy link
Member

wing328 commented Apr 10, 2024

cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@wing328 wing328 added Client: PHP Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Apr 10, 2024
@wing328
Copy link
Member

wing328 commented Apr 11, 2024

tested locally and all tests passed:

 % ./vendor/bin/phpunit tests
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

...............................................................  63 / 215 ( 29%)
............................................................... 126 / 215 ( 58%)
............................................................... 189 / 215 ( 87%)
..........................                                      215 / 215 (100%)

Time: 00:01.302, Memory: 12.00 MB

@wing328 wing328 merged commit 172c4d1 into OpenAPITools:master Apr 11, 2024
14 checks passed
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor szepeviktor deleted the patch-1 branch April 11, 2024 06:33
@szepeviktor
Copy link
Contributor Author

Making tools better is a win-win!

@wing328
Copy link
Member

wing328 commented Apr 11, 2024

Definitely 👍

FYI. We also have a new php-nextgen client generator. Please give it a try to see if it better meets your requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: PHP Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants