Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala] added new scala-cask generator for the cask framework #18344

Merged
merged 33 commits into from
Apr 10, 2024

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Apr 9, 2024

based on #18046 with minor enhancements.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title Aaronp cask3 [Scala] added new scala-cask generator for the cask framework Apr 10, 2024
@aaronp
Copy link
Contributor

aaronp commented Apr 10, 2024

Thanks so much @wing328 !

what else do you need from me to merge?

@wing328 wing328 marked this pull request as ready for review April 10, 2024 10:49
@wing328 wing328 added this to the 7.5.0 milestone Apr 10, 2024
@wing328 wing328 merged commit 2bfc5a3 into master Apr 10, 2024
79 checks passed
@wing328 wing328 deleted the aaronp-cask3 branch April 10, 2024 10:50
@aaronp
Copy link
Contributor

aaronp commented Apr 10, 2024

Thanks so much @wing328 - how can I buy you a beer/ thank you for your help?

Also, when does the next openapi docker image get built with this change?

@wing328
Copy link
Member Author

wing328 commented Apr 11, 2024

published as part of the travis ci build: https://hub.docker.com/layers/openapitools/openapi-generator-cli/latest/images/sha256-bc770a2dd3ffe4c887534500b66b549840628e53ab2d0580af6dfeb6587a6e19?context=explore

how can I buy you a beer/ thank you for your help?

Just PM you via Slack :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants