Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [kotlin-spring] Fixed escaped backticks in parameters using reserved words #18318

Merged

Conversation

franciscobretal
Copy link
Contributor

@franciscobretal franciscobretal commented Apr 7, 2024

Changes:

Tests to check the problem is fixed:

  1. Place a openapi.yml file containing the OpenAPI definition used as the bug example in the issue [BUG] [kotlin-spring] Escaped backticks in parameters using reserved words #18317.
  2. Checkout this PR's branch.
  3. Run the following CLI command. In this case, to ease testing, we use the -t flag to use the custom templates that have been edited in this branch.
openapi-generator-cli generate -i openapi.yml -g kotlin-spring -o out -t /path/to/openapi-generator/modules/openapi-generator/src/main/resources/kotlin-spring -p serviceImplementation=true -p interfaceOnly=true -p delegatePattern=true

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Closes #18317

@franciscobretal
Copy link
Contributor Author

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier

This should be a quick and easy fix

@wing328
Copy link
Member

wing328 commented Apr 7, 2024

lgtm

thanks for the fix

@wing328 wing328 merged commit a91d8e2 into OpenAPITools:master Apr 7, 2024
14 checks passed
@franciscobretal franciscobretal deleted the kotlin-spring-backtick-bug branch April 10, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [kotlin-spring] Escaped backticks in parameters using reserved words
2 participants