Fix: in typescript fixes additionalProperties handling when extending models

[mvarchdev]

Previously the extending of models when instantionTypte('map') was not set for language looked like this: class ProductData extends null<String, ProductDataBase>, this is not correct, it should look like this? class ProductData extends ProductDataBase. This PR fixes that.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh ./bin/configs/*.yaml
  ./bin/utils/export_docs_generators.sh
  

  (For Windows users, please run the script in Git BASH)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sebastianhaas @mkusaka

[wing328]

cc
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

[macjohnny]

Thanks for your contribution

[andreseloysv]

For an object like this:

Foo:
  type: object
  required:
    - id
  properties:
    id:
      type: string
  additionalProperties: {}

The current solution with typescript-node generates the following class:

export class Foo extends any {

This results in a compilation error because you cannot extend from any. In my opinion, this issue should be addressed before closing the pull request.

[mvarchdev]

@andreseloysv Will you look at that? Basicaly it should not happen that there will be additionalProperties empty, but of course it should be handled as it is edge case.

[s-xu-wafios]

Just to provide more information, in the previous version (7.4.0), for such an object

type: object
  properties:
    notificationSettings:
      push:
        type: boolean
      email:
        type: boolean
additionalProperties: true

In 7.4.0 it would generate (also not sure if it's correct)
export class Foo extends null<String, any> {

and in 7.5.0 it generates (with compilation error)
export class Foo extends any {

[mvarchdev]

extends null<String, any> is not correct and will result in compilation error and linting errors. That is the reason why I implemented this. You simply cannot extend null and null does not have any type parameters. We can put check (i do not know currently what check) so instead of extending any we can put Record<string, unknown> which is correct.

[mvarchdev]

I will create new PR for that!

[mvarchdev]

Guys, followup created #18491, CC @andreseloysv @s-xu-wafios

[mvarchdev]

CC @macjohnny @wing328 followup PR created