Fix: Always serialise Map and Set to object and array in typescript-axios

[adrianhelvikspond]

This produces type definitions that aren't compatible with the typescript-axios client:

        someField:
          uniqueItems: true
          type: array
          items:
            type: string

My fix serialises of Sets into arrays and Maps into objects, since otherwise they are not serialized with JSON.stringify, see https://stackoverflow.com/questions/31190885/json-stringify-a-set

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh ./bin/configs/*.yaml
  ./bin/utils/export_docs_generators.sh
  

  (For Windows users, please run the script in Git BASH)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

[adrianhelvikspond]

Fixes the serialization part of #11746

[wing328]

can you please follow step 3 to update the samples?

[adrianhelvikspond]

Done!

Sorry about missing the samples. Step 3 messed up some samples for all languages on Mac. Worked fine with Docker though. This script might be useful for Mac users if it happens to others:

docker run -it --rm --workdir /project -v $PWD:/project sapmachine:21-jdk-ubuntu sh -c './mvnw clean package && ./bin/generate-samples.sh ./bin/configs/*.yaml && ./bin/utils/export_docs_generators.sh'

[adrianhelvikspond]

I replaced Object.entries and Object.fromEntries with ponyfills that are compatible with the target environment.

[wing328]

can you please merge the latest master into your branch as the ts axios test failures have been fixed?

[adrianhelvikspond]

Rebased from master now.

[macjohnny]

LGTM

[macjohnny]

@adrianhelvikspond can you fix the build issue?

[adrianhelvikspond]

I updated the tsconfig so it downlevels iterators to Symbol.iterator, which is needed for map iterators.

[macjohnny]

can you rewrite the code so it does not need this change? some folks might be using the generated code without the generated tsconfig.json

[adrianhelvikspond]

Yep. I'll use forEach instead. Shouldn't expose any details about iterators, and makes it compatible with IE11 without a Symbol.iterator polyfill.

[adrianhelvikspond]

I've made the changes and updated the documentation.

[adrianhelvikspond]

And now I've rebased from master again.

[pauliusg]

@macjohnny, @wing328, @adrianhelvikspond this introduced new issue. Now Date object is serialized to {}. Request:

{ testDate: new Date() }

After serialization becomes:

{ testDate: {} }

This might happen not only with dates. Looks like you have to check if object has toJSON method. And if has, execute it for final value: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify

Had to downgrade from v7.5.0-SNAPSHOT to v7.4.0.

[macjohnny]

@adrianhelvikspond do you want to fix this?

[macjohnny]

I reverted this PR in #18452
@pauliusg thanks for reporting the issue!

[ckoegel]

This PR also changed the response for binary media, prior to 7.5.0, my response looked like:

{
      type: 'Buffer',
      data: [
        255, 216, 255, 224,  0,  16,  74, 70,  73,  70,  0,  1,
          1,   0,   0,   1,  0,   1,   0,  0, 255, 219,  0, 67,
        ... 32003 more items
      ]
    }

but it now appears as:

{
      '0': 255,
      '1': 216,
      '2': 255,
      '3': 224,
      '4': 0,
      '5': 16,
      '6': 74,
...
}
This makes it more difficult to write this data to a file. Reverting this PR helps for the time being, but we'll still need a solution for the Maps and Sets to be serialized properly.