Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scala-pekko client generator #17417

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

mickaelmagniez
Copy link
Contributor

@mickaelmagniez mickaelmagniez commented Dec 18, 2023

pekko is a fork of akka, which has recently change its licence to Business Source License.

Now than pekko-http 1.0.0 is released, openapi-generator can support pekko-http for client generation.

I've done a new generator rather than adding a flag to the scala-akka generator, because i've updated all dependencies, and removed joda-time and compat libraries

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@clasnake @jimschubert @shijinkui @ramzimaalej @chameleon82 @Bouillie @Fish86

@wing328
Copy link
Member

wing328 commented Dec 21, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Dec 21, 2023

tested locally and the result is good

[info] Fetched artifacts of 
[info] compiling 15 Scala sources to /Users/williamcheng/Code/openapi-generator7/samples/client/petstore/scala-pekko/target/scala-2.13/classes ...
[warn] /Users/williamcheng/Code/openapi-generator7/samples/client/petstore/scala-pekko/src/main/scala/org/openapitools/client/api/EnumsSerializers.scala:24:64: Wrap `enum` in backticks to use it as an identifier, it will become a keyword in Scala 3. [quickfixable]
[warn]   private class EnumNameSerializer[E <: Enumeration: ClassTag](enum: E)
[warn]                                                                ^
[warn] one warning found
[success] Total time: 34 s, completed 21 Dec. 2023, 7:42:38 pm

@mickaelmagniez
Copy link
Contributor Author

Thanks for the review, i've updated the commit author, and added the scala-pekko sample to ci

@wing328
Copy link
Member

wing328 commented Dec 22, 2023

lgtm. thanks for the contribution.

I'l file a follow-up PR with minor enhancement.

happy holidays!

@wing328 wing328 merged commit 38c33b9 into OpenAPITools:master Dec 22, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants