Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] add file download tests #17362

Merged
merged 6 commits into from
Dec 9, 2023
Merged

[Ruby] add file download tests #17362

merged 6 commits into from
Dec 9, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Dec 9, 2023

a follow-up PR to #17333

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 marked this pull request as ready for review December 9, 2023 14:02
@wing328 wing328 added this to the 7.2.0 milestone Dec 9, 2023
@wing328
Copy link
Member Author

wing328 commented Dec 9, 2023

travis CI failure not related to this change

@wing328 wing328 merged commit 10da7a3 into master Dec 9, 2023
22 of 24 checks passed
@wing328 wing328 deleted the ruby-add-tests3 branch December 9, 2023 14:05
@lumpidu
Copy link
Contributor

lumpidu commented Dec 10, 2023

I see that you have also fixed an error in the Typhoeus adapter. I used this adapter before and needed to switch to Faraday because after my upgrade to the latest OpenApi generator, this adapter stopped working.

Thx for fixing !

@wing328
Copy link
Member Author

wing328 commented Dec 11, 2023

@lumpidu thanks Daniel. Sorry for the regression. We should have added the test right away but missed it as there are too many pending works.

Thanks again for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants