Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go-server] Add ability to handle nullable query param #17321

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

lwj5
Copy link
Contributor

@lwj5 lwj5 commented Dec 5, 2023

Add the ability to handle nullable query param

nullable query params will now be passed as a pointer to the servicer.
non-nullable query params will still be passed as value.

There is no breaking changes in this PR

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@lwj5
Copy link
Contributor Author

lwj5 commented Dec 5, 2023

test cases added

cc @icubbon for any other comments

# Conflicts:
#	modules/openapi-generator/src/main/resources/go-server/controller-api.mustache
@wing328
Copy link
Member

wing328 commented Dec 21, 2023

lgtm but I've not tested it locally.

@wing328 wing328 merged commit bf4c98a into OpenAPITools:master Dec 21, 2023
19 checks passed
@wing328 wing328 added this to the 7.2.0 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants