include {min|max}Items validation in rust-server models #17201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
|
cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10) |
|
tested locally and the result is good. will add a test in another PR. |
5 tasks
wing328
reviewed
Nov 29, 2023
| @@ -296,6 +296,19 @@ pub struct {{{classname}}} { | |||
| range(min = {{minimum}}), | |||
| {{/maximum}} | |||
| {{/minimum}} | |||
| {{#maxItems}} | |||
| {{#minItems}} | |||
| length(min = {{minItems}}, max = {{maxLength}}), | |||
There was a problem hiding this comment.
maxLength should be replaced by maxItems.
caught this issue when testing with both minItems and maxItems
will fix it in #17215
There was a problem hiding this comment.
Oops, that would be the result of having used /Length/s//Items/ where /Length/s//Items/g was needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON Schema Array validation keywords
minItemsandmaxItemswere missing in the template formodel.rs.Fixes #17136