Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elm] Fix operations with empty responses #171

Merged
merged 1 commit into from
May 29, 2018

Conversation

eriktim
Copy link
Contributor

@eriktim eriktim commented May 28, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Operations without response result in invalid Elm code. This PR fixes that.

@wing328
Copy link
Member

wing328 commented May 29, 2018

@trenneman thanks for the PR. Can you please update the Elm petstore sample so that the CI can verify the change?

@wing328 wing328 added this to the 3.0.0 milestone May 29, 2018
@eriktim
Copy link
Contributor Author

eriktim commented May 29, 2018

I ran the script ./bin/elm-petstore.sh. The Petstore example isn't affected by this bug, so nothing changed.

@wing328 wing328 merged commit 5a87fe6 into OpenAPITools:master May 29, 2018
@wing328
Copy link
Member

wing328 commented May 29, 2018

@trenneman 👌 PR merged into maser 👍

@eriktim eriktim deleted the elm-fix-empty-responses branch May 29, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants