Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kotlin-spring beanValidation for RequestBody parameters #16859

Conversation

lukbaran
Copy link
Contributor

Duplicated changes from #13932 to fix #16738.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. Kotlin @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier

@wing328
Copy link
Member

wing328 commented Nov 8, 2023

thanks for the PR. Tested locally to confirm the fix:

--- a/src/main/kotlin/org/openapitools/api/AddApiController.kt
+++ b/src/main/kotlin/org/openapitools/api/AddApiController.kt
@@ -44,7 +44,7 @@ class AddApiController() {
         value = ["/add"],
         consumes = ["application/json"]
     )
-    fun addPut(@Parameter(description = "", required = true) @Valid @RequestBody body: kotlin.Int): ResponseEntity<Unit> {
+    fun addPut(@Parameter(description = "", required = true) @Valid@Min(2) @RequestBody body: kotlin.Int): ResponseEntity<Unit> {
         return ResponseEntity(HttpStatus.NOT_IMPLEMENTED)

@wing328 wing328 merged commit ced31f4 into OpenAPITools:master Nov 8, 2023
15 of 16 checks passed
@wing328
Copy link
Member

wing328 commented Nov 8, 2023

@lukbaran thanks for the PR, which has been merged. Can you please PM me via Slack when you've time? Thank you.

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328 wing328 changed the title add kotlin-spring beanValidation for RequestBody parameters fix #16738 Add kotlin-spring beanValidation for RequestBody parameters Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][KOTLIN-SPRING] Missing Bean Validation annotations on RequestBody
2 participants