Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Do not pydantic-validate function args twice #16776

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

robertschweizer
Copy link
Contributor

@robertschweizer robertschweizer commented Oct 10, 2023

refactor: Use newlines in _with_http_info call
fix: Do not pydantic-validate function args twice

Closes #15757

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 @multani

This prevents too-long lines and matches the style that
black would enforce.
@wing328 wing328 added this to the 7.1.0 milestone Oct 11, 2023
@wing328 wing328 merged commit 2b6b3b0 into OpenAPITools:master Oct 11, 2023
@multani
Copy link
Contributor

multani commented Oct 13, 2023

@robertschweizer Just checking this now (sorry for the delay!)

It seems the status of .raw_function is not really clear in Pydantic v2: according to the documentation, it's not there supported anymore, although it's still there and seems to work as expected.

Also, mypy doesn't really like when this attribute is used.

I'll try to think about something else, if we split the body of the functions as i proposed in #16788 , maybe that can offer an alternative that could also be useful to you, while keeping mypy happy :)

@robertschweizer
Copy link
Contributor Author

Good catch @multani! I wasn't aware that .raw_function is deprecated/supposed to be removed in pydantic v2. It looks a bit like pydantic devs changed their minds or forgot about removing the field after they wrote the migration guide.

Feel free to revert if this turns out to be a problem. It is just nice-to-have in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][python] Client should only run pydantic.validate_arguments once
3 participants