[csharp] fix ecdsa signing issue. #16772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method
ecdsa.SignHash()
used for signing using ECDSA key, it returns the signature in ANS1 format and we have helper functionConvertToECDSAANS1Format()
which convert ANS1 format to Der format.We have observed that the function
ConvertToECDSAANS1Format()
returns invalid signature if we run it for more than 100 times.To overcome this issue .NET5 has provided a method which can be used to generate signature for ecdsa key with DER format.
ecdsa.SignHash(dataToSign, DSASignatureFormat.Rfc3279DerSequence);
I have tested with new method it works as expected without any failure.
This method gives valid signature always and authentication happens without any fail.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@wing328