Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a flaky test DefaultCodegenTest#testVarsAndRequiredVarsPresent #16751

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Suraj-Vashista-BK
Copy link
Contributor

To fix #16750

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Oct 7, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@Suraj-Vashista-BK Suraj-Vashista-BK force-pushed the fix-flaky-test branch 2 times, most recently from 0e98a7d to 6039679 Compare October 7, 2023 13:55
@Suraj-Vashista-BK
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Thank you for your response. I have made the suggested changes and now the commit is linked to my github account.

Thanks

@wing328
Copy link
Member

wing328 commented Oct 7, 2023

can you please follow step 3 to update the samples as well?

@Suraj-Vashista-BK
Copy link
Contributor Author

can you please follow step 3 to update the samples as well?

I have followed the steps and committed the updated samples.

@Suraj-Vashista-BK
Copy link
Contributor Author

can you please follow step 3 to update the samples as well?

Hi , just checking back. Is this PR good to go?

@wing328 wing328 merged commit 494ee48 into OpenAPITools:master Oct 10, 2023
@wing328
Copy link
Member

wing328 commented Oct 10, 2023

looks good. thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JAVA][BUG] Flaky test detected - DefaultCodegenTest#testVarsAndRequiredVarsPresent
2 participants