[php-next-gen] fix handling with enums in object serializer #16741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unsure if the whole check could be removed because in the setter method of the model there is a phpdoc typehint which states that only an enum is allowed. But as long as there are no native type hints it could not be ensured that the value is always an enum.
$data
in this case should never be overwritten because it contains the OpenApi information.In my opinion serialization of the value should always be a scalar value because otherwise receiving clients must understand PHP enums serialization.
Offtopic: there are some more issues with enums, i.e. in query parameters. But I will fix them with separate pull requests so they are clean and simple.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)