Csharp/anyof oneof mixed primitive object parse error #16706
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserialization fails for C# client models using anyOf/oneOf with json primitive/array types. Triages #16686
This is the current workaround we're using with just the templates, but afaik this will produce uncompilable code if the template needs to generate a ctor with
Object
args.Rather than feeding everything to JObject which will fail for primitives/array json tokens. It uses a switch to deserialize the token appropriate to its json token type. The property setter does validation on the typing, though the types will be wrong for non-string types as JsonReader gives Int64s and Doubles back regardless of the json typing, which doesn't jive with the generated C# type validation in the setter.
I added the repro to issue data, but I was unsure where those tests would live. I saw mention of CI tests. Would that cover the in language generation?
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)