Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use model class for request body with additionalProperties #16613

Merged
merged 5 commits into from
Sep 23, 2023

Conversation

martin-mfg
Copy link
Contributor

fix #16294

For request bodies with additionalProperties, a generic Map is used as type instead of the proper model class. Even though the proper model class is generated. The proper model class is only used if generateAliasAsModel is true. This condition has been introduced in #4569 and is not really relevant, as far as I can tell. So I'm removing this particular condition.

I think this should go to the 8.0.x branch, but it doesn't seem to exist yet.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)

@wing328
Copy link
Member

wing328 commented Sep 23, 2023

@martin-mfg thanks for the PR. I would consider this PR as a bug fix.

Let's see if users prefer the "old behaviour" for whatever reason and we may come up with a way to fallback.

@wing328 wing328 merged commit 2ca99bd into OpenAPITools:master Sep 23, 2023
106 checks passed
@wing328 wing328 added this to the 7.1.0 milestone Sep 23, 2023
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
…ols#16613)

* try out simple fix

* add test case

* generate samples
@ignacioel
Copy link

Hi @martin-mfg and @wing328,
can you have a look to the following issue #17258 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA][Spring] Setting "additionalProperties" generates Spring endpoint with wrong RequestBody type
3 participants