[PHP] convert data to string before giving it to preg_match #16513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties like
generate this kind of code:
so
preg_match
receives aDateTime
objects and fails withUncaught TypeError: preg_match(): Argument #2 ($subject) must be of type string, DateTime given
To avoid that call
ObjectSerializer::toString
, which takes a value and turns it into a string. If it's a string, pass through unchanged If it's a datetime object, format it in ISO8601 If it's a boolean, convert it to "true" or "false".CC @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(7.0.1 - patch release),7.1.x
(minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)