Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp][generichost] Fixed class definition #16318

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Aug 13, 2023

Fixed class definition bug that occurs with validatable disabled, no inheritance, and none of the properties are readonly.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Aug 14, 2023

thanks for the PR. what about adding a test with readonly properties?

@devhl-labs
Copy link
Contributor Author

I would have to add a whole new sample with validatable disabled. Seems a little extreme for such a small change.

@wing328
Copy link
Member

wing328 commented Aug 14, 2023

Understood. We'll merge this for the time being.

@wing328 wing328 merged commit 47020f1 into OpenAPITools:master Aug 14, 2023
@devhl-labs devhl-labs deleted the fix-class-definition branch August 14, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants