Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spring] fix void return type for useResponseEntity: false #16230

Merged
merged 5 commits into from
Aug 7, 2023

Conversation

martin-mfg
Copy link
Contributor

fix #15966

For some configurations, illegal code like Mono<void> is created, which should be Mono<Void> (with uppercase "V") instead. This PR fixes the problem.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)

@wing328
Copy link
Member

wing328 commented Aug 2, 2023

@martin-mfg Thanks for the fix. What about adding a test in modules/openapi-generator/src/test/resources/3_0/spring/petstore-with-fake-endpoints-models-for-testing.yaml ?

@martin-mfg
Copy link
Contributor Author

martin-mfg commented Aug 6, 2023

@wing328 I added a new test.

The bug is triggered if reactive: true and useResponseEntity: false. So I created a new sample config with these settings, as none of the existing sample configs had this combination. modules/openapi-generator/src/test/resources/3_0/spring/petstore-with-fake-endpoints-models-for-testing.yam didn't even need to be changed, it contained already endpoints for which the bug was triggered.

@wing328 wing328 merged commit 6a3f0ff into OpenAPITools:master Aug 7, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [SPRING] Wrong code generation when reactive: true and useResponseEntity: false
2 participants