-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] fix missing Any and Dict import when supporting addditionalProperties #16208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s if not present - missing Any and Dict import Signed-off-by: ふぁ <[email protected]>
Signed-off-by: ふぁ <[email protected]>
Signed-off-by: ふぁ <[email protected]>
Signed-off-by: ふぁ <[email protected]>
6 tasks
Signed-off-by: ふぁ <[email protected]>
Signed-off-by: ふぁ <[email protected]>
wing328
reviewed
Jul 29, 2023
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/PythonClientCodegen.java
Show resolved
Hide resolved
Thanks for the PR. I've tested locally to confirm the fix, and filed the following to add a test to cover the issue moving forward. Have a nice weekend. |
6 tasks
wing328
changed the title
[python-nextgen] fix #16151 Disallow additional properties if not present - missing Any and Dict import
[python-nextgen] fix missing Any and Dict import when supporting addditionalProperties
Jul 29, 2023
wing328
changed the title
[python-nextgen] fix missing Any and Dict import when supporting addditionalProperties
[python] fix missing Any and Dict import when supporting addditionalProperties
Jul 29, 2023
fa0311
changed the title
[python] fix missing Any and Dict import when supporting addditionalProperties
[python-nextgen] fix missing Any and Dict import when supporting addditionalProperties
Jul 29, 2023
fa0311
changed the title
[python-nextgen] fix missing Any and Dict import when supporting addditionalProperties
[python] fix missing Any and Dict import when supporting addditionalProperties
Jul 29, 2023
@fa0311 thanks again for the PR. When you've time, can you please PM me via Slack: https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)Overview
fix #16151