Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] fix missing Any and Dict import when supporting addditionalProperties #16208

Merged
merged 6 commits into from
Jul 29, 2023

Conversation

fa0311
Copy link
Contributor

@fa0311 fa0311 commented Jul 28, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Overview

fix #16151

@wing328
Copy link
Member

wing328 commented Jul 29, 2023

Thanks for the PR. I've tested locally to confirm the fix, and filed the following to add a test to cover the issue moving forward.

#16218

Have a nice weekend.

@wing328 wing328 merged commit d9fc039 into OpenAPITools:master Jul 29, 2023
12 checks passed
@wing328 wing328 changed the title [python-nextgen] fix #16151 Disallow additional properties if not present - missing Any and Dict import [python-nextgen] fix missing Any and Dict import when supporting addditionalProperties Jul 29, 2023
@wing328 wing328 changed the title [python-nextgen] fix missing Any and Dict import when supporting addditionalProperties [python] fix missing Any and Dict import when supporting addditionalProperties Jul 29, 2023
@fa0311 fa0311 changed the title [python] fix missing Any and Dict import when supporting addditionalProperties [python-nextgen] fix missing Any and Dict import when supporting addditionalProperties Jul 29, 2023
@fa0311 fa0311 changed the title [python-nextgen] fix missing Any and Dict import when supporting addditionalProperties [python] fix missing Any and Dict import when supporting addditionalProperties Jul 29, 2023
@wing328
Copy link
Member

wing328 commented Sep 12, 2023

@fa0311 thanks again for the PR. When you've time, can you please PM me via Slack: https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Python] Disallow additional properties if not present - missing Any and Dict import
2 participants