[core] Fix NPE for endpoints without responses #1617
Conversation
jmini
changed the title
./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. - [ ] Filed the PR against the [correct branch](https://github.com/OpenAPITools/openapi-generator/wiki/Git-Branches): master~~, 3.4.x, 4.0.x~~. Default: master. - [ ] Copied the [technical committee](https://github.com/openapitools/openapi-generator/#62---openapi-generator-technical-committee) to review the pull request if your PR is targeting a particular programming language.
|
Even if not having responses defined is not a valid OpenAPI spec (it will be reported as such by editors like https://editor.swagger.io/) I think that it make sense to support this. cc @OpenAPITools/generator-core-team |
|
Um, sorry for the long title: I used command line tool ( By the way, the validator could issue a warning in such case? |
Yes. Good idea! |
|
@tomekc I have merged your change. Thank you a lot! For your idea with warnings, can you open a separated issue for that? |
|
@tomekc thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
When generating Java client, generator was crashing with cryptic NPE. After debugging, it turned out, that one of the enpoints did not have 'responses' field defined,
and there was no clue, what operation it was. The code looked like was supposed to deal with that situation, but by simple mistake it moved on and caused NPE.
Additional logging helped isolate the problem.
BTW: IntelliJ IDEA IDE suggested that change, so it is easy to spot it using static code analysis.
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)