-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix allOf with a single $ref #16096
Merged
Merged
Fix allOf with a single $ref #16096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
y-chan
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
5 tasks
Is there an ETA on a release with this fix included? I need to migrate away from 5.1.1 because I need to add Jakarta EE support (added in v6.3.0), but then I ran into #12838 with combinations of descriptions + single-ref |
6 tasks
Closed
2 tasks
ReneZeidler
pushed a commit
to ReneZeidler/openapi-generator
that referenced
this pull request
Jun 17, 2024
Fixes OpenAPITools#15077 The previous fix for this in OpenAPITools#16096 is incomplete because it still generates unnecessary inline models when readOnly or nullable is used in conjunction with other properties like description. This commit fixes the logic error and adds testcases.
ReneZeidler
pushed a commit
to ReneZeidler/openapi-generator
that referenced
this pull request
Jun 17, 2024
Fixes OpenAPITools#15077 The previous fix for this in OpenAPITools#16096 is incomplete because it still generates unnecessary inline models when readOnly or nullable is used in conjunction with other properties like description. This commit fixes the logic error and adds testcases.
5 tasks
ReneZeidler
added a commit
to ReneZeidler/openapi-generator
that referenced
this pull request
Jun 19, 2024
Fixes OpenAPITools#15077 The previous fix for this in OpenAPITools#16096 is incomplete because it still generates unnecessary inline models when readOnly or nullable is used in conjunction with other properties like description. This commit fixes the logic error and adds testcases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Inline Schema Handling
Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf
Issue: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #16047
FYI @OpenAPITools/generator-core-team
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)