Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-qt-client] Fix warning #16083

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Conversation

MartinDelille
Copy link
Contributor

@MartinDelille MartinDelille commented Jul 12, 2023

I added CMake compile option to fail on all warnings. Let's see how the CI reacts.

EDIT: I realized that I was still using an older version of openapi-generator when writing this warning fix that I already did here: f40433d

Although having the following in the test project:

add_compile_options(-Wall -Werror)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @muttleyxd

@wing328 wing328 merged commit 067b172 into OpenAPITools:master Jul 17, 2023
22 checks passed
@wing328 wing328 added this to the 7.0.0 milestone Jul 17, 2023
@MartinDelille MartinDelille deleted the fix-warning branch July 17, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants