-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cli options use tags and api name suffix #15936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -958,7 +963,7 @@ public String toApiName(String name) { | |||
return "DefaultApi"; | |||
} | |||
name = sanitizeName(name); | |||
return camelize(name) + "Api"; | |||
return camelize(name) + apiNameSuffix; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This will impact all spring code gen, not just cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but the default is "Api", correct? So nothing should happen for the other ones. The tests said it's okay :P
I think it make sense also for the other spring generator to add a name suffix if you want. Nothing special to spring-cloud
The
useTag
CLI options is currently not used for the library spring cloud for the code generation. This PR fix this issue, what is a breaking change for the spring cloud generator, since the default value is currently always 'false'.In addition, the api name suffix option is now used. This is optional because the default "Api" is still set.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)