Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support angular 16 in typescript-angular generator #15934

Closed

Conversation

twatzl
Copy link

@twatzl twatzl commented Jun 27, 2023

this PR adds support for angular 16 by updating relevant package versions in the code generating package.json.

  • rxjs
  • typescript
  • angular
  • ngPackagr

this resolves the following issue #15874

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

Copy link
Contributor

@amakhrov amakhrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! All looks good for me.

Note that there is another similar PR (opened just a day ago): #15925

The only substantial difference between the two, as I can see, is the required zone.js version for Angular 16.

@twatzl
Copy link
Author

twatzl commented Jun 28, 2023

I see. We implemented the change last week, but did not manage to open the PR until yesterday.
Anyway I don't mind which one is merged as long as everything works.

Regarding the zone.js version: might be the older one works as well. With the upgrade to angular 16 we upgraded all our frontends to zonejs 13 as well. In theory according to the docs no zonejs would be needed with angular 16 at all, but I assume that would require migration to signals.

To sum it up: I have no strong preferences here.

@akehir
Copy link
Contributor

akehir commented Jun 28, 2023

zone.js should probably be at 0.13; although in this context I'm not sure why it's necessary.

@macjohnny
Copy link
Member

superseded by #15925

@macjohnny macjohnny closed this Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants