Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openapi-normalizer] Support normalizing null types using OAS 3.1 syntax #15698

Merged

Conversation

karzang
Copy link
Contributor

@karzang karzang commented May 31, 2023

In some test specifications OAS 3.1 syntax is used to definenullable schemas in oneOf/anyOf. This change supports normalizing these definitions and avoids generating unnecessary code for null types using the SIMPLIFY_ONEOF_ANYOF option.

PR checklist

  • Read the contribution guidelines.

  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
    Run the following to build the project and update samples:

    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    

    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.

  • In case you are adding a new generator, run the following additional script :

    ./bin/utils/ensure-up-to-date
    
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)

  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

@karzang karzang changed the title [openapi-normalizer] Support nullable check for OAS 3.1 [openapi-normalizer] Support normalizing null types using OAS 3.1 syntax May 31, 2023
@karzang karzang marked this pull request as ready for review May 31, 2023 13:37
@wing328
Copy link
Member

wing328 commented Jun 3, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the 7.0.0 milestone Jun 3, 2023
@karzang
Copy link
Contributor Author

karzang commented Jun 5, 2023

I added the E-Mail in the commit to my Github account. According to your description that should fix the problem.

@wing328 wing328 merged commit bc7bdca into OpenAPITools:master Jun 5, 2023
74 checks passed
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants