Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aspnetcore] Adds {{>partial_header}} to missing mustache files #15616

Merged
merged 1 commit into from
May 24, 2023

Conversation

aramflo
Copy link
Contributor

@aramflo aramflo commented May 23, 2023

Adds {{>partial_header}} to missing mustache files

Description

Adds partial_header to missing mustache files for aspnetcore.

@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@JFCote JFCote requested a review from wing328 May 23, 2023 18:31
@JFCote
Copy link
Member

JFCote commented May 23, 2023

@wing328 I have reviewed and it looks good. Disclaimer: @aramflo is working in my team for the same company. :)

@wing328
Copy link
Member

wing328 commented May 24, 2023

LGTM

@wing328 wing328 merged commit 2042fb2 into OpenAPITools:master May 24, 2023
22 checks passed
@wing328 wing328 added this to the 7.0.0 milestone May 24, 2023
@wing328 wing328 changed the title CASS-399: Adds {{>partial_header}} to missing mustache files in aspne… [aspnetcore] Adds {{>partial_header}} to missing mustache files May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants