Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin] New 'jvm-spring-webclient' library #15568

Merged

Conversation

stefankoppier
Copy link
Contributor

New 'jvm-spring-webclient' library aiming to resolve issue 15320.

It's a first "basic" implementation with the desire to continue expanding it, and possibly other aspects of the kotlin generators. The main things to review are those in libraries/jvm-spring-webclient, KotlinClientCodegen with the result in the sample folder kotlin-jvm-spring-webclient.

Kotlin technical committee: @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

@stefankoppier stefankoppier changed the title New 'jvm-spring-webclient' library for kotlin-client [kotlin] New 'jvm-spring-webclient' library May 18, 2023
@wing328
Copy link
Member

wing328 commented May 23, 2023

Tested locally and the result is also good:

Starting a Gradle Daemon (subsequent builds will be faster)

> Task :compileKotlin
w: /private/tmp/kotlin-client/src/main/kotlin/org/openapitools/client/apis/PetApi.kt: (144, 16): 'findPetsByTagsWithHttpInfo(List<String>): Mono<ResponseEntity<List<Pet>>>' is deprecated. This operation is deprecated.
w: /private/tmp/kotlin-client/src/main/kotlin/org/openapitools/client/apis/PetApi.kt: (151, 35): 'findPetsByTagsRequestConfig(List<String>): RequestConfig<Unit>' is deprecated. This operation is deprecated.

BUILD SUCCESSFUL in 1m 26s
3 actionable tasks: 3 executed

@wing328 wing328 merged commit 9358ab9 into OpenAPITools:master May 23, 2023
44 checks passed
@wing328
Copy link
Member

wing328 commented May 23, 2023

@stefankoppier thanks for the PR, which has been merged.

@stefankoppier
Copy link
Contributor Author

@stefankoppier thanks for the PR, which has been merged.

Thanks @wing328

@wing328
Copy link
Member

wing328 commented May 23, 2023

FYI. Just merged #15608 with some minor enhancements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][Kotlin] Add spring webclient library
2 participants