-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kotlin] New 'jvm-spring-webclient' library #15568
Merged
wing328
merged 5 commits into
OpenAPITools:master
from
stefankoppier:kotlin-client-spring-webclient
May 23, 2023
Merged
[kotlin] New 'jvm-spring-webclient' library #15568
wing328
merged 5 commits into
OpenAPITools:master
from
stefankoppier:kotlin-client-spring-webclient
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
May 19, 2023
wing328
reviewed
May 19, 2023
Tested locally and the result is also good:
|
@stefankoppier thanks for the PR, which has been merged. |
Thanks @wing328 |
FYI. Just merged #15608 with some minor enhancements |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New 'jvm-spring-webclient' library aiming to resolve issue 15320.
It's a first "basic" implementation with the desire to continue expanding it, and possibly other aspects of the kotlin generators. The main things to review are those in
libraries/jvm-spring-webclient
,KotlinClientCodegen
with the result in the sample folderkotlin-jvm-spring-webclient
.Kotlin technical committee: @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m